Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

13746 fix available ips API for posting custom-fields #13889

Merged
merged 3 commits into from
Oct 5, 2023

Conversation

arthanson
Copy link
Collaborator

Fixes: #13746

Fixes AvailableObjectsView, previously the prep_object_data was using serializer.validated_data which stripped out many fields (such as custom fields). Changed to use requested_objects which will still have those fields. This data is just sent to the serializers so there is no reason to use the serializer vaildated_data as input.

@arthanson arthanson changed the title DRAFT: 13746 fix available ips API for posting custom-fields 13746 fix available ips API for posting custom-fields Sep 25, 2023
@arthanson arthanson marked this pull request as ready for review September 26, 2023 21:20
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arthanson!

@jeremystretch jeremystretch merged commit d03859b into develop Oct 5, 2023
8 checks passed
@jeremystretch jeremystretch deleted the 13746-available-ips-api branch October 5, 2023 19:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants