Fixes #12751 - Usability improvements for object selector #14387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds preselected filters * Applies the filter on selection instead of requiring the search button to be pushed
|
im wondering should we make a separate issue to mark this as fixing as #12751 lists several issues with the selector. this pr fixes part 2 of the list of issues. |
|
@ITJamie this is a great example of why it's so important to ensure each feature request conveys a concise, discrete enhancement and to not bundle multiple initiatives in a single issue. If you don't believe this PR fully resolves the FR, I'd suggest breaking out the remaining items into separate FRs so that this can move forward. |
|
@kkthxbye-code : thank you ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #12751
The typescript change was because of a bug that was also present for the Saved Filter field. If a collapsible field is defaulted to be shown, the list will not populate when opening like it is supposed to, but only when the user starts typing.
I was a bit uncertain about the
selector_fieldsname,selector_defaultorselector_default_fieldsmight be better. Feedback appreciated.The default fields were taken from the initial PR adding selector fields. I looked at what fields were removed from the forms and added them as pre-selected fields.