14147 Prevent logging to Change Log when no changes are made #14477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthanson
changed the title
jeremystretch
requested changes
Dec 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #14147
Prevents an ObjectChange record from being created if there is an update and no data has changed.
Adds a CHANGELOG_SKIP_EMPTY_CHANGES config param, default False, that allows to skip the logging if no changes. i.e. the default is the old behavior.
If this flag is set, then to_objectchange can return None which needs to be checked in overriden functions. Did it this way for performance to prevent instantiating an object and serializing data if it is never going to be used.
A side-effect of this change, which should probably be default, is the
last_updatedfield is removed from the serialized data of the changelog. The reason for this is this would be counted as a changed field when comparing the serialized records (pre / post update).Added to feature branch as it seems a big enough feature change to be in a point release.