Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #14847: Relax requirement for IKE policy #14878

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Fixes #14847: Relax requirement for IKE policy #14878

merged 2 commits into from
Jan 22, 2024

Conversation

m2martin
Copy link
Contributor

@m2martin m2martin commented Jan 20, 2024 •
edited
Loading

Fixes: #14847

  • Remove requirement for IKE mode in IKE policies
  • Remove requirement for IKE mode in IKE policies (bulk import)
  • Set IKE mode as nullable in bulk edit form
  • Modify tests
  • Add clean() to check for cases where IKE mode is mandatory (IKEv1) or where not applicable (IKEv2).
  • Add info to IKE policy model docs

jeremystretch
jeremystretch approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks @m2martin!

@jeremystretch jeremystretch merged commit 79e0d3a into netbox-community:develop Jan 22, 2024
4 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2024
@m2martin m2martin deleted the 14847-relax-ike branch August 4, 2024 11:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeremystretch jeremystretch jeremystretch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Relax requirement for IKE policy
2 participants
@m2martin @jeremystretch