Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7025 circuit redundancy #16945

Merged
merged 31 commits into from
Jul 24, 2024
Merged

7025 circuit redundancy #16945

merged 31 commits into from
Jul 24, 2024

Conversation

arthanson
Copy link
Collaborator

Fixes: #7025

@jeremystretch jeremystretch added this to the v4.1 milestone Jul 19, 2024
@arthanson arthanson changed the title DRAFT: 7025 circuit redundancy 7025 circuit redundancy Jul 22, 2024
@arthanson arthanson marked this pull request as ready for review July 22, 2024 08:28
jeremystretch
jeremystretch requested changes Jul 22, 2024
View reviewed changes
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some other notes:

  • The CircuitGroup view should include a "circuits" tab to easily list assigned circuits.

  • There should be some convenient path to assign a circuit to a group from the circuit view.

  • Looks like we're missing a search index for CircuitGroup.

netbox/circuits/models/circuits.py Outdated Show resolved Hide resolved
netbox/circuits/models/circuits.py Outdated Show resolved Hide resolved
netbox/circuits/models/circuits.py Outdated Show resolved Hide resolved
netbox/circuits/models/circuits.py Show resolved Hide resolved
netbox/circuits/models/circuits.py Outdated Show resolved Hide resolved
netbox/circuits/tests/test_filtersets.py Show resolved Hide resolved
netbox/templates/circuits/circuitgroup.html Show resolved Hide resolved
netbox/circuits/tables/circuits.py Outdated Show resolved Hide resolved
netbox/templates/circuits/circuitgroupassignment.html Outdated Show resolved Hide resolved
netbox/templates/circuits/circuitgroupassignment.html Outdated Show resolved Hide resolved
@jeremystretch jeremystretch merged commit 8237c6a into feature Jul 24, 2024
6 checks passed
@jeremystretch jeremystretch deleted the 7025-circuit-redundancy branch July 24, 2024 16:24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeremystretch jeremystretch jeremystretch requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@arthanson @jeremystretch