Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17186 change custom link button color from outline-dark to outline-se… #17248

Merged
merged 6 commits into from
Aug 27, 2024

Conversation

arthanson
Copy link
Collaborator

Fixes: #17186

The link button choices has default as outline-dark which it appends to btn- to get the button color. outline-dark will not show in dark mode, so as previous changes to other buttons change to outline-secondary. Migration was needed to change this is in the database as it uses the database char value to create the button class.

123 | NetBox 2024-08-22 12-47-15

@arthanson arthanson marked this pull request as ready for review August 22, 2024 20:05
@arthanson arthanson marked this pull request as draft August 22, 2024 20:47
@arthanson arthanson removed the request for review from jeremystretch August 22, 2024 20:47
@arthanson arthanson changed the title 17186 change custom link button color from outline-dark to outline-se… DRAFT: 17186 change custom link button color from outline-dark to outline-se… Aug 22, 2024
netbox/netbox/choices.py Outdated Show resolved Hide resolved
@arthanson arthanson changed the title DRAFT: 17186 change custom link button color from outline-dark to outline-se… 17186 change custom link button color from outline-dark to outline-se… Aug 27, 2024
@arthanson arthanson marked this pull request as ready for review August 27, 2024 16:23
@jeremystretch jeremystretch merged commit 0157ac6 into develop Aug 27, 2024
6 checks passed
@jeremystretch jeremystretch deleted the 17186-custom-link branch August 27, 2024 19:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default class custom links invisible in dark mode
2 participants