Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: #17083 - Wrap labels in a div to reduce inadvertently clickable area to their left in forms #17525

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

bctiemann
Copy link
Contributor

Fixes: #17083

Wraps all form labels in a <div class="col-sm-3"> which ensures ample dead clickable space to their left in forms, while remaining responsive.

Screenshot 2024-09-17 at 4 15 24 PM

@bctiemann bctiemann requested a review from DanSheps September 17, 2024 20:15
@bctiemann bctiemann self-assigned this Sep 17, 2024
@jeremystretch
Copy link
Member

I don't see any difference in behavior with this change applied: Clicking anywhere within the column to the left of the field still selects the label as before.

@DanSheps DanSheps self-requested a review September 19, 2024 14:43
Copy link
Member

@DanSheps DanSheps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Showing label as properly constrained now

@jeremystretch jeremystretch merged commit 8deaaae into develop Sep 19, 2024
6 checks passed
@jeremystretch jeremystretch deleted the 17083-reduce-clickable-area-labels branch September 19, 2024 17:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clickable area of input fields extends too far left
3 participants