Fixes: #17498 - Avoid error in bulk import when non-unique identifying values are provided #17584
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #17498
Extends
_clean_fields
to catchMultipleObjectsReturned
exceptions on any field where an ad-hoc accessor is used (for examplemanufacturer.description
inDeviceType
) and multiple matching records are found.With this change, a toast is displayed which surfaces the model that caused the exception. Because this is a non-field clean method, the field's specific metadata is not available, but the general message from the exception (which contains the model name) is reflected in the toast which should lead the user to a solution.
Note that other extraneous toasts appear as well as a side effect; this is not ideal, but this solution avoids the much greater issue of an opaque 500 error.