Fixes: #17732 - Add a background-color to img elements in docs to ensure readability in dark mode #17790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
requested changes
Oct 16, 2024
… of main netbox_logo.svg
|
bctiemann
force-pushed
the
17732-png-background-color-develop
branch
from
761ae23
to
eb27c5f
Compare
|
Unfortunately I don't think the white outline will comply with our branding rules for the logo. We do have dark & light versions of the logo available, and it looks like mkdocs-material does support image toggling for light & dark modes. I'll take a stab at it. |
|
Well that's better for sure. |
jeremystretch
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #17732
Adds a
background-colorproperty to theimgCSS style for docs, to ensure that PNGs with transparent backgrounds and black text are still readable even on a dark-mode background.