Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #17972: Force evaluation of LOGIN_REQUIRED when requesting static media #17990

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

jeremystretch
Copy link
Member

Fixes: #17972

Creates a new view, MediaView, to wrap Django's serve() view and enforce LOGIN_REQUIRED (if enabled) for uploaded media (e.g. image attachments).

@jeremystretch jeremystretch merged commit 954e29a into develop Nov 12, 2024
5 of 6 checks passed
@jeremystretch jeremystretch deleted the 17972-media-login-required branch November 12, 2024 17:19
jsenecal pushed a commit to jsenecal/netbox that referenced this pull request Nov 12, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Media files are reachable unauthenticated
2 participants