Fixes #17490: Config Template unable to dynamically include templates #18106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nclude templates
jeremystretch
requested changes
Dec 2, 2024
…able to avoid exhausting it on the check for None Co-authored-by: Jeremy Stretch <jstretch@netboxlabs.com>
Co-authored-by: Jeremy Stretch <jstretch@netboxlabs.com>
|
Thanks very much @jeremystretch. I went ahead and added commits for the changes you proposed. Again, kudos to @ed-ud for the initial proposed fix. Admittedly, I had spent a lot of time troubleshooting this and ended up in a similar spot, when I came back to the issue and saw there was a duplicate. |
|
Thank you both! |
|
Just a heads up that the workflow ran before I had finished all the changes. Is it possible to run it again and review? |
jeremystretch
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #17490
Config templates are unable to dynamically include child templates. This is a proposed fix as suggested by @ed-ud in #18066 which was closed as a duplicate.