-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade java, maven and versions of other dependencies #34
Upgrade java, maven and versions of other dependencies #34
Conversation
…used dependencies and plugins
…om javax.validation, because the one from hibernate is depricated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to change https://github.com/netceteragroup/valdr-bean-validation/blob/master/.travis.yml#L3 for the CI build to pass.
…ing for hibernate-validator dependency (it was relocated from org.hibernate to org.hibernate.validator)
This is taking shape quite nicely. However, the more I think about it the more hesitant I become. There's a clearly defined mapping between Bean Validation constraints and valdr Angular JS validators as per https://github.com/netceteragroup/valdr-bean-validation#mapping-of-bean-validation-constraints-to-valdr-constraints (which this PR should also update). This is established through a String match from e.g. https://github.com/netceteragroup/valdr/blob/master/src/core/validators/hibernateEmailValidator.js#L12 to https://github.com/netceteragroup/valdr-bean-validation/blob/master/valdr-bean-validation/src/main/java/com/github/valdr/BuiltInConstraint.java#L33. So, if you change I'm thinking that maybe we should add support for the Bean Validation What do you think? |
Sorry for the delay of my response. |
No description provided.