-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved locking performance on .NET 9.0+ #62
Conversation
It looks like the CI is broken. @MarkCiliaVincenti can you fix the CI error? error CA2252: '_lock''s type contains the preview type 'Lock' and requires opting into preview features. See https://aka.ms/dotnet-warnings/preview-features for more information. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2252) |
Interesting. This is happening because it's running under 9.0.100-preview.4.24267.66 instead of the latest (preview 7). I made a hopeful fix but given the workflow needs manual approval a trial-and-error approach is going to be tricky. |
It seems that manual approval cannot be canceled. |
i will try to update sdk to preview 7 |
But now the error is different. It is running on preview 7 The message timed out in the backlog attempting to send because no connection became available (5000ms) |
I improved the dependencies and test cases related to .NET 9 and specified using preview 7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Thank you for your contribution. @MarkCiliaVincenti |
The new System.Threading.Lock offers greater performance, as independent benchmarks show (eg https://steven-giesel.com/blogPost/4cf6d48a-ec9d-4c68-961c-31fd8d8c1340)