NGSTACK-870 implement vite for asset bundleing instead of webpack #196
Conversation
| @@ -97,4 +96,4 @@ | |||
| @import 'cookie_control'; | |||
|
|
|||
| // Accessibility | |||
| @import 'accessibility'; | |||
| @import 'accessibility'; | |||
| @@ -54,7 +54,8 @@ | |||
| "netgen/layouts-ibexa": "~1.4.0", | |||
| "netgen/layouts-ibexa-site-api": "~1.4.0", | |||
| "netgen/layouts-ibexa-relation-list-query": "^1.4", | |||
| "netgen/layouts-ibexa-tags-query": "^1.4" | |||
| "netgen/layouts-ibexa-tags-query": "^1.4", | |||
| "pentatrion/vite-bundle": "^6.4" | |||
There was a problem hiding this comment.
Can you please move this just below `"tanoconsulting/ibexa-migration-bundle", to keep extra dependencies not related to Netgen together?
| @@ -1,84 +1,90 @@ | |||
| { | |||
| "browserslist": { | |||
There was a problem hiding this comment.
Please revert back to 4 spaces, for more relevant diffs and easier comparison to Ibexa version of package.json
| @@ -1,4 +1,61 @@ | |||
| { | |||
| "babdev/pagerfanta-bundle": { | |||
There was a problem hiding this comment.
Do not commit this change to symfony.lock. Full symfony.lock file is only commited in projects. Here, this file exists only with minimal data to prevent Symfony Flex from destroying the repo on first install, but still allowing fresh recipes to be installed when instantiating a project.
| @@ -0,0 +1,32 @@ | |||
| import { defineConfig, loadEnv } from 'vite'; | |||
There was a problem hiding this comment.
I suppose we can now remove webpack.config.js and rename webpack.config.ibexa.js to webpack.config.js as is in the default Ibexa install. Install docs also need to be updated to remove/adapt the section for renamed webpack config file.
There was a problem hiding this comment.
Together with this, Netgen specific webpack config can be reverted back to Ibexa config in config/packages and removed in config/app/packages.
No description provided.