Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add experimental support for region selection #158

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

eduardoboucas
Copy link
Member

Which problem is this pull request solving?

Adds experimental support for region selection in Netlify Blobs. Right now, this is limited to deploy-scoped stores and is configured using a new experimentalRegion parameter of getDeployStore. It can be used as follows:

  • If experimentalRegion is set to auto, it instructs the backend to automatically pick the region that is configured for the deploy
    • This is only supported in our API endpoints, so it's not available when initialising the store with a edgeURL property
  • If experimentalRegion is set to context, it tries to load the name of the region from the environment context, throwing an error if not found
  • If experimentalRegion is unset (or set to anything else), the existing behaviour will be observed

Part of COM-585.

@eduardoboucas eduardoboucas requested a review from a team as a code owner March 28, 2024 15:33
@github-actions github-actions bot added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Mar 28, 2024
Copy link

netlify bot commented Mar 28, 2024

Deploy Preview for blobs-js ready!

Name Link
🔨 Latest commit 3793c51
🔍 Latest deploy log https://app.netlify.com/sites/blobs-js/deploys/66058de658488500079d145e
😎 Deploy Preview https://deploy-preview-158--blobs-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@biruwon biruwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eduardoboucas eduardoboucas merged commit 6734751 into main Apr 1, 2024
15 checks passed
@eduardoboucas eduardoboucas deleted the feat/region-selection branch April 1, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants