Image widget "Insert From URL" should be optional

[madsem]

The feature introduced here: https://github.com/netlify/netlify-cms/pull/4700/files
should be optional imho.

It's a great feature, but in some cases it encourages hotlinking haha.
I would prefer to be able to turn it off, just maybe like

label: "Hero Image",
      name: "image",
      widget: "image",
      choose_url: false,
      allow_multiple: false,
      default: "/img/shareable-default.jpg",
      i18n: true,

[erezrokah]

Hi @madsem, great suggestion. It would make for a great first contribution.

The relevant code is here:
https://github.com/netlify/netlify-cms/blob/c353eb761e8cca6638f95f7a75473d0f641196c0/packages/netlify-cms-widget-file/src/withFileControl.js#L303
https://github.com/netlify/netlify-cms/blob/c353eb761e8cca6638f95f7a75473d0f641196c0/packages/netlify-cms-widget-file/src/withFileControl.js#L321

in case someone would like to pick this up.

[madsem]

Thanks for pointing me in the right direction, I will have a looksy :)

[Edald123]

Hi! I'm new to the project and I would like to try this issue if no one is working on it yet. Is it possible?
If yes, is there more information I would need to start working on the issue? Thank you!

[madsem]

I have a huge work load already, so i would gladly give you the reigns :)

[Edald123]

Great, I can take it and start working on it. :D

[Edald123]

Hi! I'm working on the issue and I would like to ask:

• What would be the expected behavior of this feature?
• What would be the way that you expect to activate and de-activate the widget?
  Thank you!

[madsem]

Imho it should be activated by default, just as it is now, that way it's backwards compatible.

Accept an option to deactivate the url link, something like from_url: false.

And I personally would expect the behavior to be: Once you set from_url to false, the link to add from a url isn't shown anymore in the UI. So that a content manager can only upload images to media library or select an existing image.

[Edald123]

Thank you! I'm going to be working on that!

[Edald123]

PR created. Let me know if any changes are needed, thank you!

[erezrokah]

Closed via #5572

[madsem]

@erezrokah when will the next version be released that includes this feature?

[erezrokah]

@madsem, this was released in netlify-cms@2.10.141 and netlify-cms-app@2.15.21