Stopped the pluralization of collection name #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erquhart
suggested changes
Jul 27, 2017
| @@ -82,7 +81,7 @@ class UnpublishedListing extends React.Component { | |||
| <div className={styles.draggable}> | |||
| <Card className={styles.card}> | |||
| <UnpublishedListingCardMeta | |||
| meta={capitalize(pluralize(collection))} | |||
| meta={pluralize(collection)} | |||
There was a problem hiding this comment.
I think you meant to remove pluralize and leave capitalize.
|
@damienvdw thanks! Just one change needed, otherwise LGTM. |
|
Wow, I really need more coffee. It's fixed now 😄 |
|
Yeah, first open source PR ever ! 🎉 |
|
@damienvdw thanks, and congratulations! 🎉 |
|
a really good fix. no code is good code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Removed pluralization of collection names in the CMS.
As suggested, this is the minimalist fix for #422
- Test plan
Pass all current tests and no additional tests required.
- Description for the changelog
Stopped the pluralization of collection name