Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label_plural field to collection config #684

Closed
verythorough opened this issue Oct 12, 2017 · 7 comments
Closed

Add label_plural field to collection config #684

verythorough opened this issue Oct 12, 2017 · 7 comments

Comments

@verythorough
Copy link
Contributor

- Do you want to request a feature or report a bug?
feature

- What is the current behavior?
The label field for a given collection is displayed in all places in the UI where the collection is referenced. At the moment, this is not pluralized in any way, so a collection with label "Post" will display as simply, "Post" in the sidebar. If you change the label to "Posts," it looks good in the sidebar, but "New Posts" doesn't make sense.

We used to have programmatic pluralization, but it sometimes produced undesirable results, and was removed.

- What is the desired behavior?
It would be nice to have an optional label_plural field (or something similar), allowing implementers to specify a label version to use in cases where the UI calls for a plural. With this in place, we can bring back programmatic pluralization and use it as a default when the manual plural isn't specified.

@erquhart
Copy link
Contributor

erquhart commented Dec 8, 2017

Along with this I'd like to reintroduce automatic pluralization as a fallback, it'll work for a lot of use cases.

@verythorough
Copy link
Contributor Author

(which I did actually mention) ;)

@erquhart
Copy link
Contributor

erquhart commented Dec 9, 2017

Yikes you totally did 🤦‍♀️

@DirtyF
Copy link
Contributor

DirtyF commented Dec 10, 2017

  • use singular instead of plural for Collections on buttons (posts)

e.g. in those context, article should be singular
quick add

new post
collections-newl

@erquhart
Copy link
Contributor

Right now there is no pluralization happening in the cms, it just uses the configured collection name.

@peduarte
Copy link

peduarte commented Feb 6, 2018

Hello 👋 I'm happy to pick this issue up and raise a PR for it.

@erquhart
Copy link
Contributor

erquhart commented Feb 7, 2018

Thanks @peduarte!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants