Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make large lambda warning message more informative #578

Merged
merged 2 commits into from
Apr 20, 2023

Conversation

biruwon
Copy link
Contributor

@biruwon biruwon commented Apr 19, 2023

Summary

Test plan

  1. Visit the Deploy Preview (insert link to specific page) ...

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

Standard checks:

  • Check the Deploy Preview's Demo site for your PR's functionality
  • Add docs when necessary

🧪 Once merged, make sure to update the version if needed and that it was
published correctly.

@biruwon biruwon requested a review from a team April 19, 2023 08:22
@netlify
Copy link

netlify bot commented Apr 19, 2023

Deploy Preview for netlify-plugin-gatsby-demo-v5 ready!

Name Link
🔨 Latest commit 997beca
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-gatsby-demo-v5/deploys/64411602a65cf50008a8d5c6
😎 Deploy Preview https://deploy-preview-578--netlify-plugin-gatsby-demo-v5.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 19, 2023

Deploy Preview for netlify-plugin-gatsby-demo ready!

Name Link
🔨 Latest commit 997beca
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-gatsby-demo/deploys/64411602153bc0000860cb2d
😎 Deploy Preview https://deploy-preview-578--netlify-plugin-gatsby-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@orinokai orinokai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, much better 👍

@MarcL
Copy link
Contributor

MarcL commented Apr 19, 2023

@pieh pieh changed the title Update max lambda size message fix: make large lambda warning message more informative Apr 20, 2023
@biruwon biruwon self-assigned this Apr 20, 2023
@kodiakhq kodiakhq bot merged commit d86fd9b into main Apr 20, 2023
@kodiakhq kodiakhq bot deleted the antonio/change-error-message-to-warning branch April 20, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants