Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(prepare): remove duplicate net-tools from ${O_PKGS} #9

Closed
wants to merge 1 commit into from
Closed

fix(prepare): remove duplicate net-tools from ${O_PKGS} #9

wants to merge 1 commit into from

Conversation

myii
Copy link
Collaborator

@myii myii commented Oct 1, 2019

  • Already available in ${COMMON_PKGS}

Found when working on:

Further suggestion: how about sorting these alphabetically, within each set of quotes? E.g.

-    D_PKGS="${COMMON_PKGS} locales procps openssh-server lsb-release"
+    D_PKGS="${COMMON_PKGS} locales lsb-release openssh-server procps"

@myii
fix(prepare): remove duplicate net-tools from ${O_PKGS}
9f1af9e 
* Already available in `${COMMON_PKGS}`
@javierbertoli javierbertoli force-pushed the master branch 3 times, most recently from f7db4bc to 0151c8a Compare November 16, 2019 11:25
@javierbertoli
Copy link
Member

@myii closing this PR as the new version, using Dockerfiles does not use these scripts anymore. Fixed the duplicated entry in f966a79

@myii myii deleted the fix/remove-duplicate-package-net-tools branch November 19, 2019 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@myii @javierbertoli