Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update description and change discard-action type as identityref #10

Merged
merged 4 commits into from
Apr 26, 2024

Conversation

QiufangMa
Copy link
Collaborator

@QiufangMa QiufangMa commented Apr 25, 2024

In the abstract, I was not sure how to parse "..scheduling information such as event, policy, services, or resources..", are these examples well known and established as scheduling information?
Med: Fixed/

The introduction made sense as a motivation for the document initially, but it should be rephrased esp that the referenced modules are expected to be updated to use this common module going forward. You may create an appendix with this historical context if needed.
Med: Fixed

Section 3.1, the description is a bit sparse; also there are no examples that use this grouping. Please expand.
Qiufang: Fixed in #9.

The description inside the YANG module is old and incorrect, it says 2 groupings and focused only on iCalendar.
Qiufang: Fixed.

s/RFC XXXX: A YANG Data Model for Scheduling/RFC XXXX: A Common YANG Data Model for Scheduling/
Med: Fixed

for discard-action, is there a possibility for creating new actions in future or these two are the only ones? I am asking to make sure that the choice of modeling this as enum is correct or not.
Qiufang: Fixed

In these lists "leaf-list date-times" and "leaf-list dates", is there any ordering constraint that should be added explicitly in text?
Qiufang: No leaf-list date-times and dates definition in the current module anymore; I don't think ordering affects the recurrence rules

Section 3.4 needs more descriptive text for period and timeticks. The yang module has a long must statement for verification that should be explained here in text.

Section 3.5 needs more descriptive text for by* leaves -> "An array of the "bysecond" (or "byminut", "byhour") specifies a list of seconds within a minute (or minutes within an hour, hours of the day)." The examples in the appendix gave some hints but the description should be clearer.

s/byminut/byminute/
Med: Fixed

Appendix A.1, the text says end date is Dec 31, 2027 but the JSON says 1st Dec - "2027-12-01T18:00:00Z"
Med: Fixed

Appendix A.2, the text says Dec 1, 2025 but the example says 1st Nov - "2025-11-01T15:00:00"
Med: Fixed

yang/ietf-schedule.yang Outdated Show resolved Hide resolved
yang/ietf-schedule.yang Outdated Show resolved Hide resolved
yang/ietf-schedule.yang Outdated Show resolved Hide resolved
yang/ietf-schedule.yang Outdated Show resolved Hide resolved
yang/ietf-schedule.yang Outdated Show resolved Hide resolved
yang/ietf-schedule.yang Outdated Show resolved Hide resolved
yang/ietf-schedule.yang Outdated Show resolved Hide resolved
yang/ietf-schedule.yang Outdated Show resolved Hide resolved
@boucadair boucadair linked an issue Apr 26, 2024 that may be closed by this pull request
@QiufangMa QiufangMa merged commit 5a821df into netmod-wg:main Apr 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comments from Dhruv
2 participants