Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report local time #26

Merged
merged 1 commit into from
Jun 19, 2024
Merged

report local time #26

merged 1 commit into from
Jun 19, 2024

Conversation

boucadair
Copy link
Collaborator

schedLocalTime OBJECT-TYPE
SYNTAX DateAndTime (SIZE (11))
MAX-ACCESS read-only
STATUS current
DESCRIPTION
"The local time used by the scheduler. Schedules which
refer to calendar time will use the local time indicated
by this object. An implementation MUST return all 11 bytes
of the DateAndTime textual-convention so that a manager
may retrieve the offset from GMT time."
::= { schedObjects 1 }

   schedLocalTime OBJECT-TYPE
       SYNTAX      DateAndTime (SIZE (11))
       MAX-ACCESS  read-only
       STATUS      current
       DESCRIPTION
           "The local time used by the scheduler.  Schedules which
            refer to calendar time will use the local time indicated
            by this object.  An implementation MUST return all 11 bytes
            of the DateAndTime textual-convention so that a manager
            may retrieve the offset from GMT time."
       ::= { schedObjects 1 }
@boucadair boucadair requested a review from QiufangMa June 19, 2024 08:36
config false;
description
"Reports the local time as used by the entity that
hosts the schedule.";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
hosts the schedule.";
hosts the schedule. This parameter is only reported if schedule is expressed in local time format.";

Note that 3231 requires calendar schedules are always expressed in local time. I think if the schedule is using UTC time, no need to know the local time info.
I guess I don't really understand what time is reported by this parameter? The time when this value is retrieved? or the time when the schedule is managed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right for calendar schedules, but other types do not have such restriction.

This will report the actual local-time as seen by the entity.

No need to restrict the attribute to non UTC but leave that the manager to infer whatever useful from the parameter.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I think I can live with that.

@boucadair boucadair merged commit 738cdf1 into main Jun 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants