NETOBSERV-1902 Additionnal graphs + tab + autocomplete for UDN #656
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #656 +/- ##
==========================================
- Coverage 56.54% 56.49% -0.06%
==========================================
Files 196 197 +1
Lines 10064 10169 +105
Branches 1195 1196 +1
==========================================
+ Hits 5691 5745 +54
- Misses 4008 4053 +45
- Partials 365 371 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| // TODO: define how to split the UDN ID | ||
| // an alternative could be to use `calculated: kubeObject(K8S_UDN_Type,K8S_UDN_Namespace,K8S_UDN_Name,0)` | ||
| // from config within 3 separated fields | ||
| if (id.includes('.')) { | ||
| const parts = id.split('.'); | ||
| child = kubeObjContent(parts[1], 'UserDefinedNetwork', parts[0]); | ||
| } else { | ||
| child = kubeObjContent(id, 'ClusterUserDefinedNetwork', undefined); | ||
| } | ||
| return singleContainer(child); |
There was a problem hiding this comment.
Holding this PR until we confirm this ☝️
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description
Dependencies
netobserv/network-observability-operator#909 to get the config deployed
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.