Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support list<Type> syntax for autowiring a collection of services #293

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Support list<Type> syntax for autowiring a collection of services #293

merged 1 commit into from
Sep 22, 2023

Conversation

spaze
Copy link
Contributor

@spaze spaze commented Sep 9, 2023 •
edited
Loading

  • bug fix / new feature?

New feature
Autowiring a collection of services already supports @param Type[] $foo and @param array<int, Type>, and using @param list<Type> $foo is basically the same thing in this case. For some people, like me, using list<> better indicates that the key of the array can be ignored (or can be assumed sequential).

  • BC break? yes/no

no

  • doc PR: nette/docs#???

nette/docs#1031

@spaze
Support list<Type> syntax for autowiring a collection of services
b569644 
And for this usage and this case it's basically the same thing as Type[] and as array<int, Type>, both supported.
@spaze spaze mentioned this pull request Sep 9, 2023
Closed
spaze added a commit to spaze/michalspacek.cz that referenced this pull request Sep 11, 2023
@spaze
Change CompanyInfo to return an object with properties set in its con…
2610fe6 
…structor

Also:
- better class naming
- throwing custom exceptions, not RuntimeException
- less code in the presenter

The docblock in `CompanyInfo::__construct()` may be changed to `list<CompanyRegister>` once/if nette/di#293 is merged and released
@dg dg force-pushed the master branch 4 times, most recently from d9c3d8d to 9e58785 Compare September 22, 2023 23:56
@dg dg merged commit 5d0171a into nette:master Sep 22, 2023
@dg
Copy link
Member

dg commented Sep 22, 2023

thanks

dg pushed a commit that referenced this pull request Sep 22, 2023
@spaze @dg
Support list<Type> syntax for autowiring a collection of services (#293)
bfc6b86 
And for this usage and this case it's basically the same thing as Type[] and as array<int, Type>, both supported.
@spaze spaze deleted the spaze/list-autowiring branch September 23, 2023 00:07
dg pushed a commit that referenced this pull request Sep 23, 2023
@spaze @dg
Support list<Type> syntax for autowiring a collection of services (#293)
b716baa 
And for this usage and this case it's basically the same thing as Type[] and as array<int, Type>, both supported.
dg pushed a commit that referenced this pull request Sep 25, 2023
@spaze @dg
Support list<Type> syntax for autowiring a collection of services (#293)
516df4f 
And for this usage and this case it's basically the same thing as Type[] and as array<int, Type>, both supported.
dg pushed a commit that referenced this pull request Sep 25, 2023
@spaze @dg
Support list<Type> syntax for autowiring a collection of services (#293)
371a590 
And for this usage and this case it's basically the same thing as Type[] and as array<int, Type>, both supported.
dg pushed a commit that referenced this pull request Sep 25, 2023
@spaze @dg
Support list<Type> syntax for autowiring a collection of services (#293)
14909f1 
And for this usage and this case it's basically the same thing as Type[] and as array<int, Type>, both supported.
dg pushed a commit that referenced this pull request Sep 28, 2023
@spaze @dg
Support list<Type> syntax for autowiring a collection of services (#293)
2deec22 
And for this usage and this case it's basically the same thing as Type[] and as array<int, Type>, both supported.
dg pushed a commit that referenced this pull request Sep 28, 2023
@spaze @dg
Support list<Type> syntax for autowiring a collection of services (#293)
32a8d4a 
And for this usage and this case it's basically the same thing as Type[] and as array<int, Type>, both supported.
dg pushed a commit that referenced this pull request Sep 28, 2023
@spaze @dg
Support list<Type> syntax for autowiring a collection of services (#293)
de0e55d 
And for this usage and this case it's basically the same thing as Type[] and as array<int, Type>, both supported.
dg pushed a commit that referenced this pull request Sep 29, 2023
@spaze @dg
Support list<Type> syntax for autowiring a collection of services (#293)
0d173ff 
And for this usage and this case it's basically the same thing as Type[] and as array<int, Type>, both supported.
dg pushed a commit that referenced this pull request Sep 29, 2023
@spaze @dg
Support list<Type> syntax for autowiring a collection of services (#293)
44b2f43 
And for this usage and this case it's basically the same thing as Type[] and as array<int, Type>, both supported.
dg pushed a commit that referenced this pull request Sep 29, 2023
@spaze @dg
Support list<Type> syntax for autowiring a collection of services (#293)
b3fd5f3 
And for this usage and this case it's basically the same thing as Type[] and as array<int, Type>, both supported.
dg pushed a commit that referenced this pull request Sep 29, 2023
@spaze @dg
Support list<Type> syntax for autowiring a collection of services (#293)
8f87e02 
And for this usage and this case it's basically the same thing as Type[] and as array<int, Type>, both supported.
dg pushed a commit that referenced this pull request Sep 29, 2023
@spaze @dg
Support list<Type> syntax for autowiring a collection of services (#293)
678e23a 
And for this usage and this case it's basically the same thing as Type[] and as array<int, Type>, both supported.
dg pushed a commit that referenced this pull request Sep 29, 2023
@spaze @dg
Support list<Type> syntax for autowiring a collection of services (#293)
35c9d92 
And for this usage and this case it's basically the same thing as Type[] and as array<int, Type>, both supported.
dg pushed a commit that referenced this pull request Sep 29, 2023
@spaze @dg
Support list<Type> syntax for autowiring a collection of services (#293)
4ab04f6 
And for this usage and this case it's basically the same thing as Type[] and as array<int, Type>, both supported.
dg pushed a commit that referenced this pull request Oct 2, 2023
@spaze @dg
Support list<Type> syntax for autowiring a collection of services (#293)
53d4ad2 
And for this usage and this case it's basically the same thing as Type[] and as array<int, Type>, both supported.
dg pushed a commit that referenced this pull request Oct 2, 2023
@spaze @dg
Support list<Type> syntax for autowiring a collection of services (#293)
dd404aa 
And for this usage and this case it's basically the same thing as Type[] and as array<int, Type>, both supported.
dg pushed a commit that referenced this pull request Oct 15, 2023
@spaze @dg
Support list<Type> syntax for autowiring a collection of services (#293)
c063433 
And for this usage and this case it's basically the same thing as Type[] and as array<int, Type>, both supported.
dg pushed a commit that referenced this pull request Oct 15, 2023
@spaze @dg
Support list<Type> syntax for autowiring a collection of services (#293)
c7db224 
And for this usage and this case it's basically the same thing as Type[] and as array<int, Type>, both supported.
dg pushed a commit that referenced this pull request Oct 15, 2023
@spaze @dg
Support list<Type> syntax for autowiring a collection of services (#293)
2417bbc 
And for this usage and this case it's basically the same thing as Type[] and as array<int, Type>, both supported.
dg pushed a commit that referenced this pull request Oct 18, 2023
@spaze @dg
Support list<Type> syntax for autowiring a collection of services (#293)
7755ef3 
And for this usage and this case it's basically the same thing as Type[] and as array<int, Type>, both supported.
dg pushed a commit that referenced this pull request Oct 18, 2023
@spaze @dg
Support list<Type> syntax for autowiring a collection of services (#293)
f7f6b0b 
And for this usage and this case it's basically the same thing as Type[] and as array<int, Type>, both supported.
dg pushed a commit that referenced this pull request Oct 18, 2023
@spaze @dg
Support list<Type> syntax for autowiring a collection of services (#293)
24eca8a 
And for this usage and this case it's basically the same thing as Type[] and as array<int, Type>, both supported.
dg pushed a commit that referenced this pull request Oct 18, 2023
@spaze @dg
Support list<Type> syntax for autowiring a collection of services (#293)
0ad0ae6 
And for this usage and this case it's basically the same thing as Type[] and as array<int, Type>, both supported.
dg pushed a commit that referenced this pull request Oct 18, 2023
@spaze @dg
Support list<Type> syntax for autowiring a collection of services (#293)
2fe9a66 
And for this usage and this case it's basically the same thing as Type[] and as array<int, Type>, both supported.
dg pushed a commit that referenced this pull request Oct 18, 2023
@spaze @dg
Support list<Type> syntax for autowiring a collection of services (#293)
bca265c 
And for this usage and this case it's basically the same thing as Type[] and as array<int, Type>, both supported.
dg pushed a commit that referenced this pull request Oct 30, 2023
@spaze @dg
Support list<Type> syntax for autowiring a collection of services (#293)
93a474b 
And for this usage and this case it's basically the same thing as Type[] and as array<int, Type>, both supported.
dg pushed a commit that referenced this pull request Nov 2, 2023
@spaze @dg
Support list<Type> syntax for autowiring a collection of services (#293)
8b7961f 
And for this usage and this case it's basically the same thing as Type[] and as array<int, Type>, both supported.
dg pushed a commit that referenced this pull request Nov 2, 2023
@spaze @dg
Support list<Type> syntax for autowiring a collection of services (#293)
06072c2 
And for this usage and this case it's basically the same thing as Type[] and as array<int, Type>, both supported.
dg pushed a commit that referenced this pull request Nov 2, 2023
@spaze @dg
Support list<Type> syntax for autowiring a collection of services (#293)
7f9ef9d 
And for this usage and this case it's basically the same thing as Type[] and as array<int, Type>, both supported.
dg pushed a commit that referenced this pull request Nov 2, 2023
@spaze @dg
Support list<Type> syntax for autowiring a collection of services (#293)
8485e3e 
And for this usage and this case it's basically the same thing as Type[] and as array<int, Type>, both supported.
dg pushed a commit that referenced this pull request Nov 2, 2023
@spaze @dg
Support list<Type> syntax for autowiring a collection of services (#293)
657bef7 
And for this usage and this case it's basically the same thing as Type[] and as array<int, Type>, both supported.
dg pushed a commit that referenced this pull request Nov 2, 2023
@spaze @dg
Support list<Type> syntax for autowiring a collection of services (#293)
ddc4027 
And for this usage and this case it's basically the same thing as Type[] and as array<int, Type>, both supported.
dg pushed a commit that referenced this pull request Nov 2, 2023
@spaze @dg
Support list<Type> syntax for autowiring a collection of services (#293)
754a039 
And for this usage and this case it's basically the same thing as Type[] and as array<int, Type>, both supported.
dg pushed a commit that referenced this pull request Nov 3, 2023
@spaze @dg
Support list<Type> syntax for autowiring a collection of services (#293)
1cecf50 
And for this usage and this case it's basically the same thing as Type[] and as array<int, Type>, both supported.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spaze @dg