FIx links to doc.nette.org in README #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Or: why I dislike external sites to host essential documentation 💅
svenluijten
commented
Oct 7, 2024
| @@ -127,7 +127,7 @@ Expect::null() | |||
| Expect::array($default = []) | |||
| ``` | |||
|
|
|||
| And then all types [supported by the Validators](https://doc.nette.org/validators#toc-validation-rules) via `Expect::type('scalar')` or abbreviated `Expect::scalar()`. Also class or interface names are accepted, e.g. `Expect::type('AddressEntity')`. | |||
| And then all types [supported by the Validators](https://doc.nette.org/validators#toc-expected-types) via `Expect::type('scalar')` or abbreviated `Expect::scalar()`. Also class or interface names are accepted, e.g. `Expect::type('AddressEntity')`. | |||
There was a problem hiding this comment.
The Validation rules heading doesn't exist on the docs site, so I figured I'd link to the closest thing on the page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 2 links in this repository's README that were 404'ing. Somewhere along the way, the site was updated to include a locale in the path, but that change was never reflected in any of the links.
Preferably this would be fixed by adding a server-side redirect on the docs website (redirecting
docs.nette.org/$1todocs.nette.org/en/$1), but I'll leave the decision to do that up to you.