-
-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong IP address in info panel #416
Comments
cc @janbarasek |
@dg @petrparolek I am not sure which solution is ok. In case of production server is this behavior ok, because function But in case of production server, function Possible solutionTracy should detect current environment and in case of local environment use old IP detection method by |
what do you @dg @janbarasek think about my solution in #417 ? I combined original code from version 2.7.3 with code in 2.7.4 from @janbarasek |
@petrparolek I'm not sure your solution is safe. The IP address through the proxy may be spoofed. See my article for more information (czech language): https://php.baraja.cz/ip-adresa First you should fix your failing tests: https://travis-ci.org/github/nette/tracy/builds/675458839 Thanks. |
thx |
Version: 2.7.4
Bug Description
I tested standalone Tracy on Vagrant / Laravel Homestead.
Expected Behavior
Possible Solution
revert commit ce31ae5
The text was updated successfully, but these errors were encountered: