Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can no longer set maxAjaxRows or panelZIndex #535

Closed
adrianbj opened this issue Feb 18, 2022 · 6 comments
Closed

Can no longer set maxAjaxRows or panelZIndex #535

adrianbj opened this issue Feb 18, 2022 · 6 comments

Comments

@adrianbj
Copy link
Contributor

Version: 2.7.9 & 2.9.1

Bug Description

It doesn't seem like it's possible to override these anymore.

Steps To Reproduce

It used to be possible to set these via:

window.Tracy.panelZIndex = 100;
window.TracyMaxAjaxRows = 5;

Expected Behavior

It doesn't work in the latest versions of 2.7 or 2.9 but it used to work in earlier versions of 2.7, but I am not sure about 2.8.

I think the example suggests it should still be possible to change the maxAjaxRows:

// window.TracyMaxAjaxRows = 3;

and I don't think there is any reason to have removed the zIndex option. Further discussion about that here: #269

Thanks.

@dg
Copy link
Member

dg commented Apr 27, 2022

I tried the example ajax-fetch.php and window.TracyMaxAjaxRows works.

@adrianbj
Copy link
Contributor Author

adrianbj commented May 8, 2022

@dg - I have managed to set window.TracyMaxAjaxRows now, but I had to do it after Tracy was loaded. Before I could include that in a $customJsFiles file.

But, I am still having problems setting panelZIndex - in v2.5 you had:

Tracy = window.Tracy || {};
Tracy.panelZIndex = Tracy.panelZIndex || 20000;

but now you have:

let panelZIndex = 20000,

and

panelZIndex: Tracy.panelZIndex,

and I am struggling to figure out how to override it. Am I missing something obvious?

Thanks.

@dg
Copy link
Member

dg commented May 8, 2022

I would like you to suggest a solution, because I don't use this (and therefore it's really possible that it doesn't work at all).

@adrianbj
Copy link
Contributor Author

adrianbj commented May 8, 2022

It used to work perfectly. It's really nice to be able to set this because 20000 is higher than the dropdown menus in Processwire which means for large panels they block access to these.

Can you either revert to having panelZIndex globally scoped so it can be changed via window or could you make it configurable via a PHP setting - maybe Debugger::panelZIndex

@dg dg closed this as completed in b223a71 May 9, 2022
@dg
Copy link
Member

dg commented May 9, 2022

I tried to fix it. Only for consistency's sake, I changed window.Tracy.panelZIndex to window.TracyPanelZIndex.

@adrianbj
Copy link
Contributor Author

adrianbj commented May 9, 2022

Thanks @dg - works perfectly - it's great to have this option back - saves lots of frustrations :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants