Update to work with axios 0.19.0; Fix npm audit vulerabilities; Bump version #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakeonfire
changed the title
jakeonfire
commented
Sep 15, 2019
| 'Content-Length', 'content-length' | ||
| ]) | ||
| if (_.isString(data)) { | ||
| data = JSON.parse(data) |
There was a problem hiding this comment.
there was a mis-match b/c the request was an object but the response was JSONified
jakeonfire
commented
Sep 15, 2019
| } | ||
|
|
||
| return md5(JSON.stringify(baseConfig)) | ||
| if (headers.common) { |
There was a problem hiding this comment.
the header config is more complex to support defaults for specific request types, so this converts it into how it will look for the request
|
would love a new release with this PR 😀 |
nettofarah
approved these changes
Sep 16, 2019
|
ah, sure 😁! can't imagine anyone wouldn't be served by the update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oh, and clarify README for #6.