Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JRuby Joni dependency and its dependencies #329

Closed
Vity01 opened this issue Oct 6, 2020 · 2 comments
Closed

JRuby Joni dependency and its dependencies #329

Vity01 opened this issue Oct 6, 2020 · 2 comments

Comments

@Vity01
Copy link

Vity01 commented Oct 6, 2020

The Readme.md homepage declares there are only 3 required dependencies, but the validator depedency also include org.jruby.joni dependency which includes jcodings.jar dependency transitively (and it's pretty big jar >1MB) .
Is it really necessary? What's good for?

@stevehu
Copy link
Contributor

stevehu commented Oct 7, 2020

The JSON schema specification is designed based on Javascript regex and there are some differences in Java regex implementation. For most users, they might not care about the differences and they are good with Java regex. If users want to ensure the regex syntax is the same as the specification, they can use the JRuby regex. I think we can make the dependency optional or provided so that the end-user can decide if they need to put it into the pom.xml file. I am open to all options to support all user's requirements. Any suggestions? Thanks.

@Vity01
Copy link
Author

Vity01 commented Oct 7, 2020

Yeah, please do the dependency optional.

stevehu added a commit that referenced this issue Oct 12, 2020
fixes #329 JRuby Joni dependency and its dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants