OneOf validator is not throwing valid error if any of the child nodes has invalid schemas.

[prubdeploy]

No description provided.

[stevehu]

@prubdeploy anyOf, oneOf and allOf are very complicated in the validator and there must be some scenarios that are not captured yet. Could you please submit a unit test case to show us the exact scenario so that we can have the same base to discuss?

[jiachen1120]

@stevehu Hi Steve. A example schema for this is:

requestBody:
    required: true
    content:
        application/json:
            schema:
                required:
                    - pet
                properties:
                    oneOf:
                    - $ref: '#/components/schema/dog'
                    - $ref: '#/components/schema/cat'

If request body not match with both dog and cat, there will be two error messages within the validation result. However, only the first one will be added to reponse status (schemaValidator.doValidate only use the first validationMessage as return status).

Therefore, when user sent a request which doesn't match with both dog and cat, he may get a error message said his request doesn't match with dog. However, I think a more proper response at this momoent may be "not match with pet.oneOf". What do you think?

[stevehu]

@jiachen1120 Thanks for the example. Yes. Your error message makes sense. I have marked this issue as a bug and we need to get it fixed.

[prubdeploy]

Hi @stevehu ,
I am unable to push my changes for the Issue #354 . Could you please grant me the necessary permissions.
FYI,
@jiachen1120 @miklish

[stevehu]

@prubdeploy I have sent you an invite. Please create a branch to push your changes. Thanks.

[stevehu]

This has been merged.