Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating jackson version to 2.15 #793

Closed
jan-tosovsky-cz opened this issue May 31, 2023 · 6 comments
Closed

Updating jackson version to 2.15 #793

jan-tosovsky-cz opened this issue May 31, 2023 · 6 comments

Comments

@jan-tosovsky-cz
Copy link

jackson 2.14 branch depends on the vulnerable snakeyaml 1.33 version, while the 2.15 branch (released recently) depends on the 2.0 version.
https://github.com/FasterXML/jackson-dataformats-text/blob/2.14/yaml/pom.xml

<dependency>
    <groupId>org.yaml</groupId>
    <artifactId>snakeyaml</artifactId>
    <version>1.33</version>
</dependency>
@fdutton
Copy link
Contributor

fdutton commented May 31, 2023

@jan-tosovsky-cz Is this the CVE you are attempting to address?
https://bitbucket.org/snakeyaml/snakeyaml/wiki/CVE-2022-1471

Version 2.0 has some breaking changes that would be propagated to clients that also use snakeyaml (e.g., Spring projects). I'll investigate if we can use 2.0 if it is present on the classpath but we may not be able to require it.

@stevehu
Copy link
Contributor

stevehu commented May 31, 2023

I have executed a light-bot script to upgrade all the repositories to Jackson 2.15.1. I am doing the build and test at the moment to see if there are any broken changes. So far, there is only one issue with the timezone, and it is minor. If we have any issues, we can roll back easily.

@stevehu
Copy link
Contributor

stevehu commented May 31, 2023

We have an issue with JDK 11 build with one of the plugins introduced recently. I have opened a ticket on the plugin moditect repo.

moditect/moditect#200

@jan-tosovsky-cz
Copy link
Author

That was quick! Thanks a lot.

Btw, this CVE was reported by the Dependency Checker tool. Sometimes it is not clear if this could be somehow exploited. When I saw a fixed version, I simply filed this issue.

@mr-zepol
Copy link

mr-zepol commented Jun 2, 2023

Just out of curiosity, when this change will be released? I know version 1.0.83 was released last week but wondering about when a new release will happen, thanks

@stevehu
Copy link
Contributor

stevehu commented Jun 2, 2023

We are doing more tests to ensure that there is no issues with this version of Jackson. Once our test is completed, we will release another version. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants