Split the PatternValidator into 2 classes. #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary to guarantee that classes from org.joni and org.jcodings are only loaded when the ecma262 configuration is set. Having both in the same class and one of the class' members being a class from the before mentioned packages fails with a NoClassDefFoundException when running in an OSGI environments with the imports of the packages being optional and not present.
Codecov Report
@@ Coverage Diff @@
## master #311 +/- ##
============================================
- Coverage 70.96% 70.39% -0.57%
+ Complexity 643 637 -6
============================================
Files 74 74
Lines 2445 2466 +21
Branches 515 520 +5
============================================
+ Hits 1735 1736 +1
- Misses 506 528 +22
+ Partials 204 202 -2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to guarantee that classes from org.joni and org.jcodings are only loaded when the ecma262 configuration is set. Having both in the same class and one of the class' members being a class from the before mentioned packages fails with a NoClassDefFoundException when running in an OSGI environments with the imports of the packages being optional and not present. (fixes #307 )