Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add $comment as a NonValidationKeyword for v7 and v2019 drafts #328

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Add $comment as a NonValidationKeyword for v7 and v2019 drafts #328

merged 1 commit into from
Oct 7, 2020

Conversation

kmalski
Copy link
Contributor

@kmalski kmalski commented Oct 3, 2020

I am not sure I am able to test this change. I did not find out any idea how to do it 😄

You can find the reference to the schema here:
https://json-schema.org/understanding-json-schema/reference/generic.html#comments
and here:
https://json-schema.org/draft-07/json-schema-core.html#rfc.section.9

@codecov-commenter
Copy link

Codecov Report

Merging #328 into master will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #328      +/-   ##
============================================
+ Coverage     70.79%   70.97%   +0.18%     
- Complexity      652      653       +1     
============================================
  Files            75       75              
  Lines          2496     2491       -5     
  Branches        529      529              
============================================
+ Hits           1767     1768       +1     
+ Misses          525      520       -5     
+ Partials        204      203       -1     
Impacted Files Coverage Δ Complexity Δ
...main/java/com/networknt/schema/JsonMetaSchema.java 85.82% <ø> (+2.48%) 16.00 <0.00> (ø)
...a/com/networknt/schema/format/DomainValidator.java 24.44% <0.00%> (+0.17%) 16.00% <0.00%> (ø%)
...n/java/com/networknt/schema/JsonSchemaFactory.java 77.77% <0.00%> (+0.61%) 31.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 236967a...b867cf1. Read the comment docs.

@stevehu stevehu merged commit d37e69c into networknt:master Oct 7, 2020
@stevehu
Copy link
Contributor

stevehu commented Oct 7, 2020

I don't think we need a test case for this as long as you don't see the warning message from the log. Thanks a lot for your help.

@stevehu stevehu changed the title Add '$comment' as a NonValidationKeyword for v7 and v2019 drafts Add $comment as a NonValidationKeyword for v7 and v2019 drafts Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants