-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding walk capabilities to networknt. #336
Conversation
Updating changes to my fork
Getting latest changes from networknt
@stevehu please feel free to drop me an email if in doubt. We can discuss more about the changes through a meeting. |
Wow! It is a big addition to the library and I like the document and flow picture. It will take some time for me and others to digest. I am sure I will have questions later. Meanwhile, would you be able to merge the latest master branch to your branch so that we can easily compare them? I also send you an invitation for the write access to the repo and you can move your contribution to a branch for easy collaboration if you like. Thanks. |
Merging Changes from networknt repo.
Codecov Report
@@ Coverage Diff @@
## master #336 +/- ##
============================================
- Coverage 70.97% 69.85% -1.12%
- Complexity 653 694 +41
============================================
Files 75 80 +5
Lines 2491 2737 +246
Branches 529 567 +38
============================================
+ Hits 1768 1912 +144
- Misses 520 612 +92
- Partials 203 213 +10 Continue to review full report at Codecov.
|
@stevehu I updated my fork master branch with latest changes from networknt master branch. We can compare the changes now easily in this PR. Also I created a new branch 'schema_walk_changes' where I have my latest changes. Please let me know if you need any further help in making the merge process easy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although the changes are massive, it is separated from the validator code with careful design. All existing test cases are working, which is an indicator that there would be no impact on the validation functionalities.
@prashanthjos Please test internally and let me know if the feature is fixed. I will release it once we have your confirmation. Thanks. |
@stevehu Thank you for merging the changes. Yes there is no impact to existing validations and validators. I have tested all the changes locally. This library can now walk or validate the JSON data for a given schema. Any further changes would be minor and can be fixed through small PR's if required. I would request you to create a new release and update the jar version, so that I can start using it. |
1.0.44 is released. |
As discussed in the issue #316 , please have a look at the walk capability changes for networknt.