Validation of oneOf depends on schema order #361
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #295 appears to be caused when the validation of one element of a oneOf schema fails due to a failed 'required' block (setting ValidatorState.matchedNode to false), and a later schema succeeds without matching any 'properties' block (which would set ValidatorState.matchedNode to true).
I'm not familiar enough with the entire code to be sure that my fix is correct, but it fixes the reported testcase and I see no immediate problems.