-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing Walk Listeners Issues. #368
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging latest changes
Getting latest changes from networknt
Codecov Report
@@ Coverage Diff @@
## master #368 +/- ##
============================================
- Coverage 69.88% 69.74% -0.14%
- Complexity 693 697 +4
============================================
Files 80 81 +1
Lines 2736 2760 +24
Branches 565 556 -9
============================================
+ Hits 1912 1925 +13
- Misses 610 621 +11
Partials 214 214 Continue to review full report at Codecov.
|
stevehu
approved these changes
Jan 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Steve,
We have faced a few issues with walk listeners which was introduced in our earlier PR. The current PR fixes them, making our code more resilient, reliable and maintainable.
Can you please approve the PR and release a version. Please let me know if you have any questions.
Thanks,
Prashanth.