Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Walk Listeners Issues. #368

Merged
merged 9 commits into from
Jan 16, 2021
Merged

Conversation

prashanthjos
Copy link
Member

Hi Steve,

We have faced a few issues with walk listeners which was introduced in our earlier PR. The current PR fixes them, making our code more resilient, reliable and maintainable.

Can you please approve the PR and release a version. Please let me know if you have any questions.

Thanks,
Prashanth.

@codecov-io
Copy link

Codecov Report

Merging #368 (67d36bf) into master (1783eb5) will decrease coverage by 0.13%.
The diff coverage is 39.02%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #368      +/-   ##
============================================
- Coverage     69.88%   69.74%   -0.14%     
- Complexity      693      697       +4     
============================================
  Files            80       81       +1     
  Lines          2736     2760      +24     
  Branches        565      556       -9     
============================================
+ Hits           1912     1925      +13     
- Misses          610      621      +11     
  Partials        214      214              
Impacted Files Coverage Δ Complexity Δ
...main/java/com/networknt/schema/AllOfValidator.java 73.68% <ø> (+7.01%) 5.00 <0.00> (ø)
...c/main/java/com/networknt/schema/NotValidator.java 91.66% <0.00%> (+22.91%) 4.00 <0.00> (ø)
...in/java/com/networknt/schema/PatternValidator.java 33.33% <0.00%> (+2.08%) 2.00 <0.00> (ø)
...c/main/java/com/networknt/schema/RefValidator.java 71.66% <0.00%> (+3.41%) 13.00 <0.00> (ø)
...main/java/com/networknt/schema/ItemsValidator.java 60.00% <21.62%> (-0.87%) 18.00 <0.00> (ø)
...a/com/networknt/schema/SchemaValidatorsConfig.java 56.89% <30.00%> (-6.37%) 17.00 <1.00> (+1.00) ⬇️
...main/java/com/networknt/schema/ValidatorState.java 70.58% <37.50%> (-29.42%) 6.00 <1.00> (+1.00) ⬇️
...knt/schema/walk/DefaultItemWalkListenerRunner.java 37.50% <37.50%> (ø) 1.00 <1.00> (?)
...main/java/com/networknt/schema/OneOfValidator.java 64.00% <40.00%> (-5.32%) 9.00 <0.00> (+1.00) ⬇️
src/main/java/com/networknt/schema/JsonSchema.java 87.40% <41.66%> (-4.60%) 50.00 <2.00> (+1.00) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1783eb5...67d36bf. Read the comment docs.

@stevehu stevehu merged commit a5eca44 into networknt:master Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants