Fix for issue-366

[Krishna-capone]

The PR fixes the following:

For FailFast:

Now the OneOf Validator waits till all the subschemas are validated before throwing the exception instead of throwing the exception if the first subschema is invalid. I followed your suggestion for #209 (Looking to see if the parent schema is OneOf when deciding to throw the exception in BaseJsonValidator) and implemented it for OneOf.

If one of the subschema is valid and the other is not it does not throw exception which the current oneOf Validator does.

When all the subschemas are invalid it throws the following exception (this is an example for the test case provided):

com.networknt.schema.JsonSchemaException: $: should be valid to one and only one of the schemas but both schemas {{"type":"integer"}{"minimum":2}} are valid.

This has the detail about the subschemas. This is needed as there may be multiple oneOf conditions which are invalid in a schema and it would be difficult for the user to know which oneOf condition failed.

when neither of the subschemas are valid it throws the following exception:
com.networknt.schema.JsonSchemaException: [$: number found, integer expected, $: must have a minimum value of 2]

This has the detail about the subschemas. This detail is needed as there may be multiple oneOf conditions which are invalid in a schema and it would be difficult for the user to know which oneOf condition failed.

For Failslow:

when both of the subschemas are valid the following msg is sent:
$: should be valid to one and only one of the schemas but both schemas {{"type":"integer"}{"minimum":2}} are valid

when neither of the subschemas are valid the following messages are sent:
$: number found, integer expected
$: must have a minimum value of 2

[codecov-io]

Codecov Report

Merging #372 (093d38e) into master (a5f9f7f) will decrease coverage by 0.23%.
The diff coverage is 60.00%.

@@             Coverage Diff              @@
##             master     #372      +/-   ##
============================================
- Coverage     69.74%   69.51%   -0.24%     
- Complexity      697      700       +3     
============================================
  Files            81       81              
  Lines          2760     2778      +18     
  Branches        556      560       +4     
============================================
+ Hits           1925     1931       +6     
- Misses          621      630       +9     
- Partials        214      217       +3     

Impacted Files	Coverage Δ	Complexity Δ
...n/java/com/networknt/schema/BaseJsonValidator.java	66.07% <50.00%> (-1.21%)	21.00 <2.00> (+1.00)	⬇️
...main/java/com/networknt/schema/OneOfValidator.java	59.82% <62.06%> (-4.18%)	11.00 <2.00> (+2.00)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5f9f7f...093d38e. Read the comment docs.

[stevehu]

@prubdeploy Could you please review the changes to ensure that your use case won't be impacted. It looks good to me in my initial review as all existing test cases are passed. Thanks.

[guillomep]

I have the exact same case, where I want to retrieve "children" errors when the OneOf fails.

[stevehu]

@guillomep It is nice to know this feature is welcomed. Could you please help to review the changes? Just want to make sure it covers your use case. Thanks.

[guillomep]

Beside my reviews I think it is okay.

[prubdeploy]

@prubdeploy Could you please review the changes to ensure that your use case won't be impacted. It looks good to me in my initial review as all existing test cases are passed. Thanks.
@stevehu The changes look good to me and doesn't impact my case and infact cover more scenarios as OneOf is considered.

[stevehu]

I tried to copy the original file to your branch and it works without any issue. I am wondering why some of the test cases are removed only in the draft4.

[stevehu]

Thanks a lot for your help. I have released a new version.

https://github.com/networknt/json-schema-validator/releases/tag/1.0.48

[guillomep]

Thank you !
Do you know when it will be available on Maven Central ?

[stevehu]

Sonatype is down today. It will take some time for it to recovery.

https://status.maven.org/?utm_source=embed

[stevehu]

Sonatype is up and running. The release should be available from the maven central. Enjoy!!!