Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test case and potential fix for #383 #384

Merged
merged 1 commit into from
Mar 14, 2021

Conversation

JonasProgrammer
Copy link
Contributor

  • signal nodeMatch to parent handler in OneOfValidator

- signal nodeMatch to parent handler in OneOfValidator
@codecov-io
Copy link

Codecov Report

Merging #384 (09b2b04) into master (e692d47) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #384      +/-   ##
============================================
+ Coverage     69.53%   69.63%   +0.09%     
- Complexity      705      707       +2     
============================================
  Files            81       81              
  Lines          2764     2766       +2     
  Branches        561      562       +1     
============================================
+ Hits           1922     1926       +4     
+ Misses          627      626       -1     
+ Partials        215      214       -1     
Impacted Files Coverage Δ Complexity Δ
...main/java/com/networknt/schema/OneOfValidator.java 61.01% <100.00%> (+1.53%) 12.00 <0.00> (+1.00)
.../main/java/com/networknt/schema/JsonSchemaRef.java 91.66% <0.00%> (+8.33%) 5.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e692d47...09b2b04. Read the comment docs.

@stevehu stevehu merged commit ca1847a into networknt:master Mar 14, 2021
@stevehu
Copy link
Contributor

stevehu commented Mar 14, 2021

@JonasProgrammer Thanks a lot for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants