-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 426 custom message #440
Conversation
@adilath18 Thanks a lot for your help. |
@stevehu |
The first contribution is the hardest and I am glad you had an enjoyable experience. Again, thanks a lot for your help and welcome onboard. |
Hi, I am trying to use the custom message feature. I believe the message implementation should be moved to the attribute level. { } in the getMessageNode we should be using the schemanode directly and get the required message. |
@sambireddyg @stevehu @adilath18 "prop1": {
"type": "string",
"maxLength": 5,
},
"prop2": {
"type": "string",
"maxLength": 10,
}, I need custom messages for both |
@everyone I think it is always a good idea to give users more options to customized the error messages. @sambireddyg @nitishborade would you like to try it out and submit a PR? Thanks. |
@stevehu I would like to look into adding this functionality, should I create a new issue to track this or just open a PR to start a discussion? |
Opening a new issue is always better than submitting a PR directly to encourage discussions. Thanks. |
@stevehu
#426 Documentation for Custom Error Message
PR: #438