$ref caching issue #443
Merged
$ref caching issue #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging latest changes
Getting latest changes from networknt
…idator into networknt-master
Fixing concurrency and compilation issues. (networknt#385)
…idator into networknt-master
|
@stevehu can you please have a look at this PR. |
|
@stevehu this review has been pending for a while. We have an important functionality that is waiting for this PR to be merged. Can you please take a look and let me know your comments. |
stevehu
approved these changes
Sep 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a scenario where we use the same
JsonSchemaFactoryto create multipleJsonSchemainstances with each instance having its own config (which is instance ofSchemaValidatorsConfig) the cached $ref's are picking up the initial config that was set by first call toJsonSchemaFactory.getSchema. This PR addresses the issue of refreshing the config every time we callJsonSchemaFactory.getSchema. As per my understanding we should be caching the JSONNode instance associated with a schema and not the config.@stevehu can you please have a look at the PR and let me know your suggestions and approve it if we are good.