Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#686 Better localisation support #743

Merged
merged 1 commit into from
May 6, 2023
Merged

#686 Better localisation support #743

merged 1 commit into from
May 6, 2023

Conversation

costas80
Copy link
Contributor

@costas80 costas80 commented May 5, 2023

PR to implement #686 .

@codecov-commenter
Copy link

Codecov Report

Merging #743 (006b7c7) into master (6382ac6) will increase coverage by 0.08%.
The diff coverage is 88.76%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##             master     #743      +/-   ##
============================================
+ Coverage     74.54%   74.62%   +0.08%     
- Complexity     1052     1056       +4     
============================================
  Files           110      110              
  Lines          3665     3673       +8     
  Branches        708      708              
============================================
+ Hits           2732     2741       +9     
  Misses          651      651              
+ Partials        282      281       -1     
Impacted Files Coverage Δ
...in/java/com/networknt/schema/ErrorMessageType.java 50.00% <50.00%> (-50.00%) ⬇️
src/main/java/com/networknt/schema/JsonSchema.java 91.62% <50.00%> (+1.30%) ⬆️
...n/java/com/networknt/schema/BaseJsonValidator.java 77.94% <55.55%> (+0.08%) ⬆️
...n/java/com/networknt/schema/ValidationMessage.java 68.60% <66.66%> (ø)
...a/com/networknt/schema/SchemaValidatorsConfig.java 72.07% <81.25%> (+1.54%) ⬆️
...a/com/networknt/schema/CustomErrorMessageType.java 100.00% <100.00%> (+12.50%) ⬆️
...rc/main/java/com/networknt/schema/I18nSupport.java 66.66% <100.00%> (ø)
...c/main/java/com/networknt/schema/RefValidator.java 90.12% <100.00%> (+0.12%) ⬆️
...n/java/com/networknt/schema/ValidatorTypeCode.java 95.87% <100.00%> (-0.05%) ⬇️

@stevehu stevehu merged commit 1d674ad into networknt:master May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants