Escape single quotes in validation messages (#898) #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdurrenmatt
force-pushed
the
issue-898
branch
4 times, most recently
from
93b3214
to
0713460
Compare
sdurrenmatt
force-pushed
the
issue-898
branch
from
0713460
to
f3ea78b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #899 +/- ##
=========================================
Coverage 79.38% 79.38%
Complexity 1228 1228
=========================================
Files 121 121
Lines 3905 3905
Branches 743 743
=========================================
Hits 3100 3100
Misses 515 515
Partials 290 290 ☔ View full report in Codecov by Sentry. |
|
@sdurrenmatt Thanks a lot for your help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #898 by representing single quotes with doubled single quotes in every validation message.