Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #2339 allow the req or res body encoding to be customized per p… #2340

Merged
merged 1 commit into from
Sep 18, 2024
Merged

fixes #2339 allow the req or res body encoding to be customized per p… #2340

merged 1 commit into from
Sep 18, 2024

Conversation

stevehu
Copy link
Contributor

@stevehu stevehu commented Sep 18, 2024

…ath prefix

@stevehu stevehu merged commit edce763 into master Sep 18, 2024
1 check passed
@stevehu stevehu deleted the issue2339 branch September 18, 2024 18:14
DiogoFKT
DiogoFKT reviewed Sep 18, 2024
View reviewed changes
Copy link
Contributor

@DiogoFKT DiogoFKT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'd add an extra unit test case for extra space at the end of pathPrefix line to test if required .isEmpty() check for encoding or not

@stevehu
Copy link
Contributor Author

stevehu commented Sep 19, 2024

@DiogoFKT Thanks for the comment. It is a defect indeed. I have fixed it with the following PR.
#2344

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiogoFKT DiogoFKT DiogoFKT left review comments

@KalevGonvick KalevGonvick Awaiting requested review from KalevGonvick

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevehu @DiogoFKT