Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Policy route protocol and port #129

Merged
merged 2 commits into from
Mar 14, 2022
Merged

Conversation

LionelJouin
Copy link
Member

@LionelJouin LionelJouin commented Mar 2, 2022

Description

  • port rename to dst_port
  • dst_port and proto type changed to string (previously uint32)
  • src_port added
  • Port range parser

Issue link

#127

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

* port rename to dst_port

* dst_port and proto type changed to string (previously uint32)

* src_port added

* Port range parser

Signed-off-by: Lionel Jouin <lionel.jouin@est.tech>
@edwarnicke
Copy link
Member

@LionelJouin This looks good. You can see examples here

exclude-rules:
of how to fix the linter check.

@edwarnicke
Copy link
Member

@LionelJouin If you can fix the linting error I can merge this and networkservicemesh/sdk-kernel#425

Signed-off-by: Lionel Jouin <lionel.jouin@est.tech>
@edwarnicke edwarnicke merged commit fe3ca75 into networkservicemesh:main Mar 14, 2022
nsmbot pushed a commit to networkservicemesh/sdk that referenced this pull request Mar 14, 2022
…i@main

PR link: networkservicemesh/api#129

Commit: fe3ca75
Author: Lionel Jouin
Date: 2022-03-14 14:50:17 +0100
Message:
  - Policy route protocol and port (#129)
* Policy route protocol and port

* port rename to dst_port

* dst_port and proto type changed to string (previously uint32)

* src_port added

* Port range parser

Signed-off-by: Lionel Jouin <lionel.jouin@est.tech>

* Disable funlen linter on helpers tests

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants