Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap forwarder interfaces. #8

Merged

Conversation

VitalyGushin
Copy link

@VitalyGushin VitalyGushin commented Feb 6, 2024

Signed-off-by: Vitaliy Guschin <vitaliy.guschin@spirent.com>
@VitalyGushin VitalyGushin force-pushed the swap-forwarder-interfaces branch from 9f62cc3 to f89cc62 Compare February 6, 2024 12:44
@denis-tingaikin
Copy link
Member

@VitalyGushin Could you also attach a picture of how it looks now?

@VitalyGushin
Copy link
Author

@VitalyGushin Could you also attach a picture of how it looks now?

done

Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remote case looks good with the patch. Have you tested it with local cases?

model_utils.go Outdated Show resolved Hide resolved
model_utils.go Outdated Show resolved Hide resolved
Signed-off-by: Vitaliy Guschin <vitaliy.guschin@spirent.com>
@VitalyGushin
Copy link
Author

Remote case looks good with the patch. Have you tested it with local cases?

For local cases interfaces on forwarders also will be swapped

Signed-off-by: Vitaliy Guschin <vitaliy.guschin@spirent.com>
@VitalyGushin VitalyGushin force-pushed the swap-forwarder-interfaces branch from 06a0b91 to f15ebc2 Compare February 14, 2024 06:02
@denis-tingaikin denis-tingaikin merged commit 56b5cde into networkservicemesh:main Feb 14, 2024
12 checks passed
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Feb 14, 2024
…d-dashboard-backend@main

PR link: networkservicemesh/cmd-dashboard-backend#8

Commit: 56b5cde
Author: Denis Tingaikin
Date: 2024-02-14 10:39:40 +0300
Message:
  - Merge pull request #8 from VitalyGushin/swap-forwarder-interfaces
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants