add main module for ovs forwarder #3
Conversation
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>
TODO: replace local sdk-ovs with upstream sdk-ovs in go.mod Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>
pperiyasamy
force-pushed
the
main-module
branch
from
743f1de
to
99dc1ff
Compare
pperiyasamy
changed the title
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>
main.go
Outdated
| // ******************************************************************************** | ||
| // setup context to catch signals | ||
| // ******************************************************************************** | ||
| ctx, cancel := getTermSigalContext() |
There was a problem hiding this comment.
I'd recommend using signal.NotifyContext
main.go
Outdated
| func getTermSigalContext() (ctx context.Context, stop context.CancelFunc) { | ||
| return signal.NotifyContext( | ||
| context.Background(), | ||
| os.Interrupt, | ||
| // More Linux signals here | ||
| syscall.SIGHUP, | ||
| syscall.SIGTERM, | ||
| syscall.SIGQUIT, | ||
| ) | ||
| } |
There was a problem hiding this comment.
I'd counsel moving this to being inline, as it makes it clearer what's happening. Wrapping a single function call in a function call reduces the clarity of what is going on.
Please note, this point is a matter of taste, so feel free to disagree with me here. I offer this as advice, not as 'You need to fix this to get merged'.
There was a problem hiding this comment.
@edwarnicke agree with your point, have changed back using signal.NotifyContext as inline function call.
|
|
||
| starttime := time.Now() | ||
|
|
||
| log.FromContext(ctx).Infof("executing phase 1: get config from environment (time since start: %s)", time.Since(starttime)) |
There was a problem hiding this comment.
Once again, as a matter of personal taste, I find this style: https://github.com/networkservicemesh/cmd-forwarder-vpp/blob/e9103cf238a4b5c8449ef04170c4ccf78cbce523/main.go#L111-L113 easier to read... you are more than welcome to have a differing opinion :)
There was a problem hiding this comment.
sure, fixed it accordingly without making changes to linter settings. hope its ok now.
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>
This is the main forwarder module hosting grpc endpoint for ovs forwarder which establishes vWire connection between service clients and endpoints.
Signed-off-by: Periyasamy Palanisamy periyasamy.palanisamy@est.tech