Adapt cmd-forwarder-sriov to use opentracing #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tigrulya-exe
commented
Nov 11, 2020
tigrulya-exe
commented
- Added jaeger initialization and tracing grpc options
- Go version was updated to 1.15
added 2 commits
November 11, 2020 18:32
Signed-off-by: Tigran Manasyan <tigran.manasyan@xored.com>
Signed-off-by: Tigran Manasyan <tigran.manasyan@xored.com>
tigrulya-exe
force-pushed
the
adapt-to-opentracing
branch
from
a5ddd83 to
e859642
Compare
added 2 commits
November 11, 2020 18:51
Signed-off-by: Tigran Manasyan <tigran.manasyan@xored.com>
Signed-off-by: Tigran Manasyan <tigran.manasyan@xored.com>
denis-tingaikin
requested changes
Nov 12, 2020
| run: docker pull ${GOLANGCI_LINT_CONTAINER} | ||
| - name: Run golangci-lint | ||
| run: docker run --rm -v $(pwd):/app -w /app ${GOLANGCI_LINT_CONTAINER} golangci-lint run | ||
| uses: actions/checkout@v2 |
|
No more need this PR. Everything is already OK. |
|
Closing by #22 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.