Make vxlan port configurable (#341) #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zolug
force-pushed
the
vxlan-port
branch
3 times, most recently
from
ae6006d
to
076c128
Compare
|
https://github.com/networkservicemesh/sdk-vpp/pull/394/files is merged. @zolug Could you please update sdk-vpp via |
networkservicemesh/sdk-vpp commit message: Make vxlan port configurable (see networkservicemesh/sdk-vpp#394) networkservicemesh/sdk commit message: Make vxlan port configurable (see networkservicemesh/sdk#1091) Signed-off-by: Zoltan Lugossy <zoltan.lugossy@est.tech>
tiswanso
reviewed
Oct 13, 2021
| @@ -41,6 +41,7 @@ type Config struct { | |||
| LogLevel string `default:"INFO" desc:"Log level" split_words:"true"` | |||
|
|
|||
| TunnelIP net.IP `desc:"IP to use for tunnels" split_words:"true"` | |||
| VxlanPort uint16 `default:"0" desc:"VXLAN port to use" split_words:"true"` | |||
There was a problem hiding this comment.
shouldn't the default be 4789?
There was a problem hiding this comment.
Internally it will translate to the default vxlan port value (4789).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
networkservicemesh/sdk-vpp commit message:
Make vxlan port configurable
networkservicemesh/sdk commit message:
Make vxlan port configurable
Signed-off-by: Zoltan Lugossy zoltan.lugossy@est.tech