Add AF_XDP support #849
Merged
Add AF_XDP support #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glazychev-art
force-pushed
the
af_xdp
branch
4 times, most recently
from
9be0582
to
4f1a810
Compare
| } else { // If we don't have a VPPAPISocket, start VPP and use that | ||
| if err = cfg.VppInit.Decode("AF_PACKET"); err != nil { | ||
|
|
||
| if err = cfg.VppInit.Decode("NONE"); err != nil { |
There was a problem hiding this comment.
I see that this if branch comes from the main. But the decode looks unnecessary here. I think we should do decode once on env config decoding.
There was a problem hiding this comment.
This Decode("NONE") was added for Calico-VPP.
Since forwarder uses an external VppAPISocket, Calico already created a management interface and we don't need to do it again (even if the settings has "AF_PACKET" or "AF_XDP").
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
denis-tingaikin
approved these changes
Apr 24, 2023
|
@edwarnicke Feel free to add comments on these changes and we'll consider them in separate PR. |
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Apr 25, 2023
…d-forwarder-vpp@main PR link: networkservicemesh/cmd-forwarder-vpp#849 Commit: a15565e Author: Artem Glazychev Date: 2023-04-25 16:20:27 +0700 Message: - Add AF_XDP support (#849) * Add AF_XDP support Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Fix review comments Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
that referenced
this pull request
Sep 13, 2024
…k-vpp@main PR link: networkservicemesh/sdk-vpp#849 Commit: d1cb444 Author: Nikita Skrynnik Date: 2024-09-13 19:32:28 +0700 Message: - add logs before creating and deleting tap intefaces (#849) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
AF_XDPsupport for the management interface.Main changes:
af_xdpAPI callIssue: #283