fix: use correct context to close connection #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
edwarnicke
reviewed
Feb 24, 2021
| @@ -186,7 +186,7 @@ func main() { | |||
| } | |||
|
|
|||
| defer func() { | |||
| closeCtx, cancelClose := context.WithTimeout(ctx, rootConf.RequestTimeout) | |||
| closeCtx, cancelClose := context.WithTimeout(context.Background(), rootConf.RequestTimeout) | |||
| defer cancelClose() | |||
There was a problem hiding this comment.
Why context Background here?
There was a problem hiding this comment.
Because else the client will not close his connection.
Because ctx will be done at the moment :)
There was a problem hiding this comment.
I can see not using the same context (as noted, it will be expired)... but we should have some timeout on the Close... perhaps note the amount of time left on the 'request' ctx and use that as duration for the new context for Close?
There was a problem hiding this comment.
I read this too quickly, this is exactly write as currently written.
ljkiraly
pushed a commit
to Nordix/nsm-cmd-nsc
that referenced
this pull request
Apr 29, 2021
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
nsmbot
pushed a commit
that referenced
this pull request
Jan 18, 2024
This PR syncs files with https://github.com/networkservicemesh/cmd-template Revision: https://github.com/networkservicemesh/cmd-template/commits/117d18197554b69cb2ceaf9a57563634940d5d22 commit 117d18197554b69cb2ceaf9a57563634940d5d22 Author: Nikita Skrynnik <93182827+NikitaSkrynnik@users.noreply.github.com> Date: Thu Jan 18 20:14:40 2024 +1100 [qfix] delete tag param from create-release job (#127) Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Denis Tingaikin denis.tingajkin@xored.com